New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command other than pick no longer work in git-xbase #472

Closed
ThiemoVanEngelen opened this Issue Jul 10, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@ThiemoVanEngelen

When performing an interactive rebase with git-xbase, changing the command does change the combo box, but the file written to disk for git does not reflect the new command.
I checked this by also saving the file to some other fixed directory.

I think this regression is caused by commit bd20bc2.
This commit moves a lot of code from decorate_item to decorate, except for the following lines:

           combo.connect(combo, SIGNAL('currentIndexChanged(const QString &)'),
                         lambda s: self.set_command(item, s))

This causes the changes to not be received by the widget item, so it does not update self.command.

By adding the following to the decorate function, things are working again:

        combo.connect(combo, SIGNAL('currentIndexChanged(const QString &)'),
                      lambda s: parent.set_command(self, s))

@davvid davvid closed this in 0bbfc62 Jul 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment