-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when choosing Launch Diff Tool on Windows #492
Comments
Thanks for the report. @living180 do you have any thoughts? Would a reasonable solution be to force @albertdev can you verify whether it's well-behaved when you unset |
Opening the difftool works when I remove I'd prefer not to do this as it means I cannot use shortened Python scripts on the command line, but I guess it's a workaround... |
Thanks for checking. That tells me that we should probably ignore |
Can you also please list what your Reading the code, I'm curious how it ever gets to the point where it tries to execute Ahhh.. I think I see what's going on. Do you have git-cola's I think your PATHEXT might be fine. The |
I now see what's up. I think the latest code should fix it ~ the problem was we had a lingering bug from a while back that was tickled by your custom |
Thanks for the quick turnaround! I can confirm that this works after patching For the record, here's how my
|
I have a file with status modified and right-click it to press Launch Diff Tool in the context menu. I'm then greeted by this error:
Tested with git-cola v2.3.
I've been debugging this issue so here's my results.
This is what the
args
variable looks like beforecore._win32_find_exe
is executed on line 189:Looks fairly normal. This is what argv looks like on line 197 (note that I'm running a copy of git-cola to insert
print
statements):I've checked
_win32_find_exe
and it seems this issue only occurs if you have.PY
in thePATHEXT
environment variable. Because git-cola is near the start of the PATH,git.PY
is found and taken for the git binary.Seeing how git-cola starts git just fine in other places, wouldn't it be possible to call git with an absolute path to the git binary for this case as well?
The text was updated successfully, but these errors were encountered: