New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Create branch" dialog does not populate "Branch Name" correctly when selecting a remote branch with slashes in the name #496

Closed
djhaskin987 opened this Issue Sep 11, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@djhaskin987

djhaskin987 commented Sep 11, 2015

Steps to Reproduce

  1. Branch > Create Branch...
  2. Select the Tracking branch radio button.
  3. Select a remote branch with a forward slash (/) in the name. For example, origin/feature/my-feature-branch.

Problem

When these steps are completed, I expect to see the "Branch Name" text field populated with "feature/my-feature-branch". Instead, it is populated with "my-feature-branch". This does not track with git checkout feature/my-feature-branch, which creates a branch called feature/my-feature-branch that tracks the branch of the same name from the remote origin.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Sep 11, 2015

Member

I was thinking about this the other day. The fix should be simple.. give me a sec... thanks for the report.

Member

davvid commented Sep 11, 2015

I was thinking about this the other day. The fix should be simple.. give me a sec... thanks for the report.

@davvid davvid closed this in 830e252 Sep 11, 2015

@mathstuf

This comment has been minimized.

Show comment
Hide comment
@mathstuf

mathstuf Sep 12, 2015

Contributor

I'm going through old emails and came across one for git-cola and saw this commit at the top when I decided to pop back in and see how it's going :) . So, remotes can also have '/' in the name (e.g., I name github remotes gh/$username). I don't know if git exposes a tool to split the remote from the branch name or not, but it's another corner case.

Contributor

mathstuf commented Sep 12, 2015

I'm going through old emails and came across one for git-cola and saw this commit at the top when I decided to pop back in and see how it's going :) . So, remotes can also have '/' in the name (e.g., I name github remotes gh/$username). I don't know if git exposes a tool to split the remote from the branch name or not, but it's another corner case.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Sep 12, 2015

Member

I just pushed an additional safeguard that allows for slashes in remote names too. You can have slashes in branches and remotes, no problem. See 34d6853

Member

davvid commented Sep 12, 2015

I just pushed an additional safeguard that allows for slashes in remote names too. You can have slashes in branches and remotes, no problem. See 34d6853

@djhaskin987

This comment has been minimized.

Show comment
Hide comment
@djhaskin987

djhaskin987 Sep 14, 2015

Yay! Thanks. Rebuilding.

djhaskin987 commented Sep 14, 2015

Yay! Thanks. Rebuilding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment