New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include the extended description when selecting a commit to fixup #522

Closed
nocnokneo opened this Issue Nov 11, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@nocnokneo

nocnokneo commented Nov 11, 2015

Is there any value in including the extended description when selecting a commit to fixup? My preference for fixup commits is describe only what is being "fixed up". When I decide to squash (i.e. replace fixup! with squash! in the commit summary) then I definitely don't want the previous extended description. Maybe there are workflows that actually make use of these extended descriptions? If so, then it probably makes sense to keep them since deleting the extended description (Ctrl+a, Delete) is a lot easier than manually adding it in.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Nov 12, 2015

Member

I think we should remove the extended description from there. Only the subject line matters, and we should match what git commit --fixup <sha1> does by using just fixup! <subject> as the message.

Member

davvid commented Nov 12, 2015

I think we should remove the extended description from there. Only the subject line matters, and we should match what git commit --fixup <sha1> does by using just fixup! <subject> as the message.

@nocnokneo

This comment has been minimized.

Show comment
Hide comment
@nocnokneo

nocnokneo Nov 12, 2015

Sounds like a good rationale to me.

nocnokneo commented Nov 12, 2015

Sounds like a good rationale to me.

@davvid davvid closed this in a98cd50 Jan 3, 2016

@nocnokneo

This comment has been minimized.

Show comment
Hide comment
@nocnokneo

nocnokneo commented Jan 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment