Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large icons and no auto focus on OS X #572

Closed
max5it opened this issue May 8, 2016 · 1 comment
Closed

Large icons and no auto focus on OS X #572

max5it opened this issue May 8, 2016 · 1 comment

Comments

@max5it
Copy link

max5it commented May 8, 2016

git-cola: version starting from version 2.4 and upto current (2.6)
OS X: 10.11.4 (15E65)
MacBook Pro (Retina, 15-inch, Mid 2015)

  1. I see very large icons comparing with v2.3

v2.6
git-cola icons

v2.3
git-cola icons 2 3

  1. Focus is not auto set to currently selected file when I switch between files (using up and down arrow keys) in "Status" sub-window and when selection go out window boundaries. So, when I use keyboard to switch between files, the content of the "Status" window stays static.
@max5it max5it changed the title Mac Large icons and no auto focus on OS X May 8, 2016
@davvid
Copy link
Member

davvid commented May 9, 2016

I'm closing this since it's a duplicate of #550

I wonder if this is a PyQt4 issue that's already been fixed in PyQt5 or PySide. At the code level the only difference we made was swapping in a resolution-independent .svg file in place of a fixed-size .png.

If this is a PyQt4 issue then #232 is related so we'll need to make a choice between PyQt5 and PySide.

I'll test this again next time I have a chance. It's odd because when I tried it last time on my 15" retina MBP I didn't see this issue. I don't remember if it was running yosemite or elcap or whatever as it's been a long time since I've used it. FWIW I don't see this issue on my retina (quad-hd) linux laptop so the issue seems to be something related to PyQt4.

Regarding 2) I can't reproduce that one either, and may similarly not be an issue when we upgrade to Qt5. I can imagine that maybe Apple changed some APIs between mavericks and el cap that broke Qt4 so the only way to support bleeding edge osx versions would be to use Qt5.

@davvid davvid closed this as completed May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants