New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+C closes commit failed dialog #734

Closed
joshnoe opened this Issue Oct 10, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@joshnoe

joshnoe commented Oct 10, 2017

To reproduce:

  1. Fail a commit
  2. Click "Show Details"
  3. Highlight some text and click "Ctrl+C"

Expected: Text is copied
Actual: Text is not copied, dialog is closed

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Oct 11, 2017

Member

woah, nice find. What OS are you on? We actually don't have Ctrl+C anywhere for close, but we do use CLOSE = QKeySequence.Close in cola/hotkeys.py. Usually what we really want is Esc for closing, regardless of platform.

It's possible that Qt may be following the OS convention and mapping Ctrl+C to Close, unfortunately.

Are you on Windows? If you can verify that you're on Windows then we can add an OS-specific tweak to use Qt.Key_Esc instead of QKeySequence.Close. IIRC, both Linux and macOS use Esc, but maybe it's not worth using QKeySequence anymore on all platforms, so we should just use our own definition instead of relying on QKeySequence. Thanks for the heads-up.

Member

davvid commented Oct 11, 2017

woah, nice find. What OS are you on? We actually don't have Ctrl+C anywhere for close, but we do use CLOSE = QKeySequence.Close in cola/hotkeys.py. Usually what we really want is Esc for closing, regardless of platform.

It's possible that Qt may be following the OS convention and mapping Ctrl+C to Close, unfortunately.

Are you on Windows? If you can verify that you're on Windows then we can add an OS-specific tweak to use Qt.Key_Esc instead of QKeySequence.Close. IIRC, both Linux and macOS use Esc, but maybe it's not worth using QKeySequence anymore on all platforms, so we should just use our own definition instead of relying on QKeySequence. Thanks for the heads-up.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Oct 11, 2017

Member

Nope, that doesn't seem to be related, actually. We're using a built-in Qt widget for the prompt, so this is definitely an OS or Qt-specific issue. What version of Qt are you using?

Member

davvid commented Oct 11, 2017

Nope, that doesn't seem to be related, actually. We're using a built-in Qt widget for the prompt, so this is definitely an OS or Qt-specific issue. What version of Qt are you using?

@et304383

This comment has been minimized.

Show comment
Hide comment
@et304383

et304383 Aug 1, 2018

I am seeing issues with Control-C not copying either. Please fix.

I'm using Ubuntu 18.04.

Right click copy works.

et304383 commented Aug 1, 2018

I am seeing issues with Control-C not copying either. Please fix.

I'm using Ubuntu 18.04.

Right click copy works.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Aug 2, 2018

Member

We've since switched to a custom widget. Fix forthcoming.

Member

davvid commented Aug 2, 2018

We've since switched to a custom widget. Fix forthcoming.

@davvid davvid closed this in 3864cc0 Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment