Pushing ignores remote.<name>.pushurl #83

Closed
bmjames opened this Issue Jun 21, 2011 · 2 comments

Comments

Projects
None yet
2 participants
@bmjames

bmjames commented Jun 21, 2011

When pushing with git-cola, the URL pushed to is always the URL in remote.<name>.url, even if remote.<name>.pushurl has been set in the repo's config.

If pushurl has been configured for the remote, that should be used instead of url.

@bmjames bmjames closed this Jun 21, 2011

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jun 30, 2011

Member

Thanks bmjames. This is still a bug, I think. Well, cola should be pushing to the right location but the GUI will mislead you by not honoring pushurl when displaying the URLs.

cola does "git push origin master" under the hood so it's really "push" that honors pushurl.
cola should check that config when figuring out the URL so that the dialog shows the real push URL.

Member

davvid commented Jun 30, 2011

Thanks bmjames. This is still a bug, I think. Well, cola should be pushing to the right location but the GUI will mislead you by not honoring pushurl when displaying the URLs.

cola does "git push origin master" under the hood so it's really "push" that honors pushurl.
cola should check that config when figuring out the URL so that the dialog shows the real push URL.

@davvid davvid reopened this Jun 30, 2011

@ghost ghost assigned davvid Jun 30, 2011

@davvid davvid closed this in 3f136a4 Jul 1, 2011

@bmjames

This comment has been minimized.

Show comment
Hide comment
@bmjames

bmjames Jul 1, 2011

Thanks @davvid, I closed the issue as soon as I found that git was doing the correct thing when pushing. But it is nice to see the correct URL displayed, too.

bmjames commented Jul 1, 2011

Thanks @davvid, I closed the issue as soon as I found that git was doing the correct thing when pushing. But it is nice to see the correct URL displayed, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment