Small cosmetic change #874
Conversation
There was a problem hiding this comment.
Hi, thanks for the sug. Please move the imports near the top of the file, below import os, rather than inline in the function.
When committing, please sign off on your commits (Ctrl+i in the commit message editor). Please read here for what it means to signoff on your commits in this project:
https://github.com/git-cola/git-cola/blob/master/CONTRIBUTING.md#sign-your-work
Lastly, please rebase and squash your commits together so that we don't have that intermediate whitespace commit. I use a lot of "fixup" commits for that kinda stuff.
I forgot to mention that (unfortunately) there's a duplicate stanza in bin/git-dag that needs to be updated in tandem. Any change like this one that lessens the number of lines of code in the standalone scripts is a good change.
Thanks!
|
Is placement of import ok? I like to separate different imports, so I've separate it with additional newline. |
|
Wait, it failed? Why? |
Signed-off-by: Jakub Szymański <jakubmateusz@poczta.onet.pl>
I did not know you mean EXACTLY under |
|
Thank you so much for fixing these, much appreciated. |
* WaxyMocha/patch-1: Switch from assigning aliases to importing used functions. Signed-off-by: David Aguilar <davvid@gmail.com>
No description provided.