Fix logo #877
Merged
Fix logo #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow XML formatters to reindent SVG's markup content. Refer-to: xmllint failed to properly `--format` certain SVG image (#16) · Issues · GNOME / libxml2 · GitLab <https://gitlab.gnome.org/GNOME/libxml2/issues/16> Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
Using known formatter to allow future modifications. Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
Eliminate attributes that are only local machine relevant, privacy leaking and simply not useful for diff-ing. The tool used to do the job is a personal project "Clean Filter for SVG" and is accessible at https://github.com/Lin-Buo-Ren/Clean-Filter-for-SVG , the actual code that do the XML processing: [1]. HTML Tidy must be run with the contrib/svg.tidy config to restore the current markup style. [1] https://github.com/Lin-Buo-Ren/Clean-Filter-for-SVG/blob/0ff326b/Clean%20Filter%20for%20SVG.bash#L351-L432 Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
* Fix aspect ratio to 1:1 * Use base-2 side length Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
|
The markup formatting tool, Tidy, can be installed on most GNU+Linux distributions via the snap:
|
davvid
added a commit
to davvid/git-cola
that referenced
this pull request
Aug 29, 2018
* Lin-Buo-Ren/fix-icon: logo: Make logo 512x512px logo: Drop unnecessary attributes logo: Reformat SVG markup using HTML Tidy contrib: Implement HTML Tidy config for SVG formatting/cleanup logo: Drop xml:space attribute Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logo has some issues:
This PR addresses most of the problems and resizes the logo to 512x512px, most graphical details are kept approximately intact.