Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create --force-with-lease equivalent checkbox on push dialog #946

Closed
jm4R opened this issue Apr 4, 2019 · 1 comment
Closed

Create --force-with-lease equivalent checkbox on push dialog #946

jm4R opened this issue Apr 4, 2019 · 1 comment

Comments

@jm4R
Copy link
Contributor

jm4R commented Apr 4, 2019

Currently we have force checkbox, but force-with-lease is safer alternative and in most cases should be used instead:
https://git-scm.com/docs/git-push#Documentation/git-push.txt---force-with-leaseltrefnamegt

I think the version without additional arguments will be enough for now.

@davvid
Copy link
Member

davvid commented Apr 5, 2019

Sounds good. Let's dig up the version number where the feature appeared and we can add a force-with-lease version value to the _version table in cola/version.py.

When self.action == 'PUSH' and version.check_git('force-with-lease') is true we can use 'force_with_lease', and 'force' otherwise.

https://github.com/git-cola/git-cola/blob/master/cola/widgets/remote.py#L519

@davvid davvid closed this as completed in 1cf66d6 Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants