Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Keyboard navigability of amend confirm dialog #965

Closed
ewjoachim opened this issue Jul 17, 2019 · 1 comment
Closed

Regression: Keyboard navigability of amend confirm dialog #965

ewjoachim opened this issue Jul 17, 2019 · 1 comment

Comments

@ewjoachim
Copy link

Version: 3.3 (utuntu 19.04)
Gnome: 3.32.1

Screenshot from 2019-07-17 14-13-36

On the confirm dialog to amend a commit that's been pushed, we used to be able to change selection using tab. Now, the only way to select "Amend commit" is with the mouse.

If you point me to the general area where this is done, I might be able to do a PR :)

@davvid davvid closed this as completed in 8c45b78 Jul 21, 2019
@davvid
Copy link
Member

davvid commented Jul 21, 2019

Thanks for the heads-up. I ended up fixing this myself, but for the record some updates were needed to the MessageBox class in cola/widgets/standard.py.

In case it helps, we have a pre-existing hotkey you can use to make it even easier. Instead of using "tab", you can use "y" to confirm the dialog, or "n" to reject it. Tab works now too though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants