Add filtering capabilities for build server data. #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSnoozer
reviewed
Aug 10, 2019
| @@ -152,7 +169,7 @@ protected void maybePut(@Nonnull Properties properties, @Nonnull String key, Sup | |||
| if (properties.contains(keyWithPrefix)) { | |||
| String propertyValue = properties.getProperty(keyWithPrefix); | |||
| log.info("Using cached {} with value {}", keyWithPrefix, propertyValue); | |||
| } else { | |||
| } else if (PropertiesFilterer.isIncluded(keyWithPrefix, includeOnlyProperties, excludeProperties)) { | |||
|
Thank you for your contribution! Indeed this seems and sounds reasonable. I personally honestly don't know in which weird cases Changes look good for me. I'm going ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The changes introduced in #185 do not cover the issue reported in #354 where a call to
getHostName()may take a long time when getting the propertygit.build.host. Likewise, in certain (rare) cases,TimeZone.getTimeZone()may also have an impact upon performance when retrievinggit.build.time.Depending on the number of projects, this may have a large effect on compile times as there may be numerous calls to the affected functions. A user should be able to filter these properties from being fetched so that build times can improve if this becomes an issue. This also further aligns with the changes in #185 to be more consistent with not fetching unused properties.
Contributor Checklist
mvn clean packagecheckstylecoding style definition:mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B