-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone install does not override GCM bundled with Git for Windows #188
Comments
Hi @ivan-paleo! Thanks for trying out GCM Core 😁 , and sorry you've encountered some issues.
Just to check I'm following correctly, you first installed GCM Core 2.0.252.766, and then installed Git for Windows 2.28 (selecting GCM Core from the installer)? I think I might know what's going on here.. the GCM Core version bundled with the Git for Windows installer is an older version (2.0.194) with a known bug with storing credentials. The version bundled with Git for Windows is taking precedence and being used over the manually installed one. To confirm this is the case, can you run the following from a command prompt window? cd path\to\your\repo
SET GCM_TRACE=1
git fetch You should see some trace logging from GCM Core printed out. What do you see for the version number (first line)? Is is version 2.0.194 or 2.0.252?
|
Thank you @mjcheetham for the feedback! Here is the output: Now I'll try re-installing Git Credential Manager Core and update my answer. EDIT: I've now uninstalled and re-installed Git Credential Manager Core and the same happens (same version, same issues). |
Hi @ivan-paleo,
You are correct. We've identified a bug (or rather a bad design assumption) in our installer for GCM Core that I'll start working on shortly. The issue is because of the order in which Git looks over the Thanks again for picking up on this! 😄 |
In the meantime, I'll revert to the old manager and wait for the bug fix :) |
It seems to be resolved with the installation of Git 2.29.0. The output of the commands
is now: |
@ivan-paleo, yes. Git for Windows 2.29 includes the latest available version of GCM Core, so it doesn't matter which version is picked (the bundled one, or the standalone one). I am still working on a fix for the standalone installer, so that GCM Core "vNext" would be able to override 2.0.252 bundled with Git for Windows 2.29 😁 |
This issue was corrected in #199 by now always using the full path to the standalone GCM Core after installation. The (older) bundled version will no longer be used in this case. The fix will be included in the next release of GCM Core. |
I have been using the Git Credential Manager (default during Git installation on Win10) until now. But I have read that it is deprecated and that I should use the Git Credential Manager Core instead.
So I have installed the latest release (2.0.252.766) and re-installed Git (2.28.0) selecting the new credential helper.
But now, I have to enter my credentials every time I want to pull or push; they are not saved anymore.
To check, I re-installed Git and selected the old helper again, and my credentials are saved again.
So it seems I have some configuration issues here.
Not sure if this is relevant: I am using 2FA so my password is a token, and I am using Codeberg.org.
I have noticed that when I use the new helper, only 1 credential gets added to the Windows Credential Manager:
git:https://username@codeberg.org
But when I use the old helper, 2 credentials are added:
git:https://username@codeberg.org
(although I'm not sure anymore whether it was newly created or whether I forgot to delete it from before)git:https://codeberg.org
The text was updated successfully, but these errors were encountered: