Empty username and password proxy config should enable WIA/default credentials #216
Closed
4 of 16 tasks
Labels
bug
A bug in Git Credential Manager
Comments
|
For reference here the log with the old gcm. Works not perfectly - will not accept the password entered in the GUI but stores the password that is entered in the command line. But anyway Password auth will be deactivated soon. |
|
Hi @CarliJoy, thanks for reporting this issue. Can I ask if you've set any username/password in the proxy configuration? I can see the following in the GCM Core trace output, which looks correct to me: According to the proxy code, we should be doing the same thing as the old GCM. Namely that if a user has specified a proxy URI and no username/pass then we should be setting According to the
In GCM Core, we set this property to In GCM for Windows the equivalent code looked like this: var proxy = new WebProxy(proxyUri) { UseDefaultCredentials = true };
// check if the user has specified authentications (comes as UserInfo)
if (!string.IsNullOrWhiteSpace(proxyUri.UserInfo) && proxyUri.UserInfo.Length > 1)
{
... omited ...
if (hasUserNameAndPassword)
{
... omitted ...
proxy.UseDefaultCredentials = false;
proxy.Credentials = proxyCreds;
}
}
return proxy;(Set Can you try running a Fiddler trace to see what specific communications and auth is happening on the wire between your proxy server and the client? |
|
Empty user and password is set for proxy (see the : before the @) I am not sure If I manage to do fiddler. Have to try if I can get this tool or something similar running without admin privileges (company policy 🙄) Maybe the Without the ":" git itself is not working properly as it tries to gather the username and password first. |
Aha! Yes! This is the issue.
This I was not aware of, to be honest. We can update GCM Core to treat an empty user/pass value as I'll update this issue once the fix is in the main branch, and then once a release is available with the fix. For a workaround before then.. If you omit the |
mjcheetham
changed the title
|
@CarliJoy the fix has been merged in and should be available in the next release. Watch this space! |
|
@mjcheetham Thanks a lot :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Which version of GCM Core are you using?
From a terminal, run
git-credential-manager-core versionand paste the output.Git Credential Manager version 2.0.280-beta+1f4c6db90f (Windows, .NET Framework 4.0.30319.42000)Which Git host provider are you trying to connect to?
Can you access the remote repository directly in the browser using the remote URL?
From a terminal, run
git remote -vto see your remote URL.[Azure DevOps only] What format is your remote URL?
{org}@dev.azure.com/{org}/...{org}.visualstudio.com/...[Azure DevOps only] If the account picker shows more than one identity as you authenticate, check that you selected the same one that has access on the web.
Expected behavior
Github Login Popup open, the Browser opens, I am authenticated and the git command run through by connecting to the Proxy using NTLM auth.
Actual behavior
Github Login Popup opens, the Browser opens and tells me that I am authenticated but gcm-core fails to connect to the proxy
Notes
The authentication works fine with the outdated
gcmsettingin the
git-credential-manger.exe.configfile. But even if I add these settings to the gcm-core config file, it won't work.PS: Some more detailled logs for errors connecting to proxies would be great (i.e. what kind of authentication was tried)
Logs
The text was updated successfully, but these errors were encountered: