Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git action to check if project is compiling #46

Closed
guyluz11 opened this issue Sep 30, 2022 · 1 comment · Fixed by #51
Closed

Add git action to check if project is compiling #46

guyluz11 opened this issue Sep 30, 2022 · 1 comment · Fixed by #51
Assignees
Labels
feature request A new feature that got requested good first issue Good for newcomers hacktoberfest Support Hacktoberfest open source event https://hacktoberfest.digitalocean.com/

Comments

@guyluz11
Copy link
Collaborator

Currently, there isn't an automatic way for the project to check if it is getting compiled for each new pr.

For that we need a git action that checks

  1. If the project is compiling.
  2. Project tests are passing.

I have done it before so you can use my version and tweak it a little bit.
Make sure that there is at least one test and all the tests are passing, if there is no test create one that just passes for the automation to work.

Link to my git action that works (for a flutter project)
https://github.com/CyBear-Jinni/cbj_app/blob/master/.github/workflows/dart.yml

@guyluz11 guyluz11 added good first issue Good for newcomers feature request A new feature that got requested hacktoberfest Support Hacktoberfest open source event https://hacktoberfest.digitalocean.com/ labels Sep 30, 2022
@git-elliot
Copy link
Collaborator

I guess it's already there as a half steps in .github/workflows/flutter_release.yml. One just need to strip the code out till the "Run tests" step

@git-elliot git-elliot linked a pull request Oct 3, 2022 that will close this issue
@git-elliot git-elliot self-assigned this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A new feature that got requested good first issue Good for newcomers hacktoberfest Support Hacktoberfest open source event https://hacktoberfest.digitalocean.com/
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants