Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitk's "touching paths" is broken (has both false positives and false negatives) #3914

Closed
1 task done
anthonyvdotbe opened this issue Jun 24, 2022 · 1 comment
Closed
1 task done

Comments

@anthonyvdotbe
Copy link

  • I was not able to find an open or closed issue matching what I'm seeing

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
$ git --version --build-options

git version 2.36.0.windows.1
cpu: x86_64
built from commit: ea1e13f73339d57cbe81a0bae6fba669aaccf656
sizeof-long: 4
sizeof-size_t: 8
shell-path: /bin/sh
feature: fsmonitor--daemon
  • Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
$ cmd.exe /c ver

Microsoft Windows [Version 10.0.22000.739]
  • What options did you set as part of the installation? Or did you choose the
    defaults?
> type "C:\Program Files\Git\etc\install-options.txt"

Editor Option: Notepad
Custom Editor Path:
Default Branch Option:
Path Option: Cmd
SSH Option: ExternalOpenSSH
Tortoise Option: false
CURL Option: WinSSL
CRLF Option: CRLFCommitAsIs
Bash Terminal Option: MinTTY
Git Pull Behavior Option: FFOnly
Use Credential Manager: Enabled
Performance Tweaks FSCache: Enabled
Enable Symlinks: Enabled
Enable Pseudo Console Support: Disabled
Enable FSMonitor: Disabled
  • Any other interesting things about your environment that might be related
    to the issue you're seeing?

Not that I can think of.

Details

  • Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

PowerShell Core 7.2.4

mkdir foo
pushd foo
git init
echo a > a.txt
git add a.txt
git commit -m a
echo b > b.txt
git add b.txt
git commit -m b
echo aa > a.txt
echo bb > b.txt
git add a.txt b.txt
git commit -m ab
gitk
Find commit touching paths: a.txt
  • What did you expect to occur after running these commands?

Only commits a and ab are highlighted.

  • What actually happened instead?

Commits b and ab are highlighted.

@rimrul
Copy link
Member

rimrul commented Jun 24, 2022

This regression in git diff-tree --stdin has been fixed in Git 2.36.1.

Duplicate of #3815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@rimrul @anthonyvdotbe and others