Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider fixing problems reported by adapter checker #166

Closed
19 of 20 tasks
mcm1957 opened this issue May 25, 2023 · 4 comments
Closed
19 of 20 tasks

Please consider fixing problems reported by adapter checker #166

mcm1957 opened this issue May 25, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request waiting Waiting for external action or input
Milestone

Comments

@mcm1957
Copy link

mcm1957 commented May 25, 2023

Please add missing languages. a simple npm run translate should do the joib if using the up-to-date release of dev-tools (https://github.com/ioBroker/adapter-dev)

Thanks for your support
McM1957

          ## Automated adapter checker

ioBroker.e3dc-rscp

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Add comment "RE-CHECK!" to start check anew

Originally posted by @GermanBluefox in ioBroker/ioBroker.repositories#2310 (comment)

@git-kick git-kick self-assigned this May 26, 2023
@git-kick git-kick added the enhancement New feature or request label May 26, 2023
@git-kick git-kick added this to the v1.2.3 milestone May 26, 2023
@git-kick
Copy link
Owner

I fixed the translation stuff and removed gulpfile.js

But after searching for an hour, I cannot figure out how to fix:

[W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI

@mcm1957, could you give me some starting point or template which I have to follow?

@git-kick git-kick added the waiting Waiting for external action or input label May 26, 2023
@ka-vaNu
Copy link
Contributor

ka-vaNu commented May 26, 2023

Perhaps you want to have a look at my blebox-Adapter. I've implemented/configured a AdminUI5 https://github.com/ka-vaNu/ioBroker.blebox/blob/master/admin/jsonConfig.json

@mcm1957
Copy link
Author

mcm1957 commented May 26, 2023

Sorry for the confusion and misleading warning. The check does not distinguish between exsiting and new adapters.
Please feel free to ignore Warning W156.

ioBroker supports a new kind of Userinterface (jsonConfig) since admin 5. Its recommended for simple Interfaces which do not use the complex react interface which in turn allows miuch more complex config systems.

Currently theres NO need to migrate a working config. Keep the option in evidence only if you need to perform major changes to the config.

Examples of jsonConfig can be viewed by a demo adpater mcm1957/ioBroker.jsonConfig-demo.

But to repeat, this warning kan be ignored currently witghout any negative effect.

As far as I can see, ALL tasks are done which apply to existing adapters.
THANKS FOR YOUR EFFORT !

@git-kick
Copy link
Owner

Ok @mcm1957 , thanks for your quick check & response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting Waiting for external action or input
Projects
None yet
Development

No branches or pull requests

3 participants