Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to download file with its only url #38

Open
Yopai opened this issue Aug 7, 2015 · 2 comments
Open

Unable to download file with its only url #38

Yopai opened this issue Aug 7, 2015 · 2 comments

Comments

@Yopai
Copy link
Contributor

Yopai commented Aug 7, 2015

Hi, thanks for the LFS-mechanism, that's great !

If I try to download an object directly with its url - the one I read in the , I got a 404.
http://localhost:8080/_user_/repo/objects/_sha_

It should rather return a 403, and allow downloading the file after authentication - and in password useless case (Issue #29), it should directly deliver the file.

And the management console, in the "Objects" tab, should link each sha to download the file.

Let me know your remarks about that, I can (try to) implement it in a PR.

@rubyist
Copy link
Contributor

rubyist commented Aug 17, 2015

I think you're right, the authentication handling isn't quite right. I'd be happy to take a PR, otherwise I can get to it shortly.

@Yopai
Copy link
Contributor Author

Yopai commented Aug 17, 2015

Got an eye in the code (and got it back, it helps)
In fact, there's a 404 because mux routes check the Accept header.
So, I well understood, - in the current state of the app - there is to :

  • add a generic route handler which catches anything not having the correct Accept Header
  • send a 406 (Not Acceptable),
    right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants