Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFS_HOST insufficient when using HTTPS -> HTTP reverse proxy #66

Open
elonen opened this issue Sep 28, 2017 · 0 comments
Open

LFS_HOST insufficient when using HTTPS -> HTTP reverse proxy #66

elonen opened this issue Sep 28, 2017 · 0 comments

Comments

@elonen
Copy link

elonen commented Sep 28, 2017 •
edited

I have a use case, where I'm trying to use Apache reverse proxy to act as a HTTPS reverse proxy that redirect https://HOST/git-lfs/ to a backend lfs-test-server that's serving HTTP on locahost-only port 9999 (with non-root user that doesn't have access to SSL certificates).

The problem is, if I set LFS_HOST to https://HOST/git-lfs/, lfs-test-server builds malformed URLs like http://https://HOST/git-lfs/.

I propose checking if LFS_HOST starts with a protocol definition, and if so, omitting the http:// prefix it normally adds.
@elonen elonen mentioned this issue Sep 28, 2017
Open
@elonen elonen changed the title LFS_HOST insufficient when using HTTPS -> backend HTTP reverse proxy LFS_HOST insufficient when using HTTPS -> HTTP reverse proxy Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elonen