Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: choose locale in settings #189

Merged
merged 3 commits into from Feb 14, 2021
Merged

feat: choose locale in settings #189

merged 3 commits into from Feb 14, 2021

Conversation

shreyas1599
Copy link
Contributor

pd4d10
pd4d10 reviewed Feb 4, 2021
View reviewed changes
lib/app.dart Outdated Show resolved Hide resolved
lib/models/theme.dart Outdated Show resolved Hide resolved
@shreyas1599
Copy link
Contributor Author

Found a parser. But it's present in a different library. The Locale class of the default(sky_engine) is different from the Locale class of the intl library I used. Hence I'm not assigning parsedLocale in the file directly to the locale prop.

@pd4d10 pd4d10 merged commit 717b7cd into pd4d10:main Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pd4d10 pd4d10 pd4d10 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shreyas1599 @pd4d10