Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star and unstar button sometimes not working #47

Closed
max-hk opened this issue Apr 4, 2020 · 4 comments
Closed

Star and unstar button sometimes not working #47

max-hk opened this issue Apr 4, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@max-hk
Copy link

max-hk commented Apr 4, 2020

Pressing star and unstar button in repo page sometimes does nothing

Demo video:
https://imgur.com/a/ZHyHcs2

In the video, I press star button multiple times.
The button was expected to be replaced by unstar button, but nothing happens.

@pd4d10 pd4d10 added the bug Something isn't working label Apr 4, 2020
@pd4d10
Copy link
Owner

pd4d10 commented Apr 5, 2020

Hi, @MaxLOh , thanks for the feedback!

It seems caused by GitHub's token scope policy update. The solution would depend on the login approach:

  1. Login with OAuth: Go to Me -> Switch accounts to login again. It would ask you the extra notification permission and please say yes.
  2. Login with token: Go to https://github.com/settings/tokens and find the token used in GitTouch, add notification scope and save.

@max-hk
Copy link
Author

max-hk commented Apr 5, 2020

Hi, @MaxLOh , thanks for the feedback!

It seems caused by GitHub's token scope policy update. The solution would depend on the login approach:

  1. Login with OAuth: Go to Me -> Switch accounts to login again. It would ask you the extra notification permission and please say yes.
  2. Login with token: Go to https://github.com/settings/tokens and find the token used in GitTouch, add notification scope and save.

I tried the mentioned steps but the problem persists.

Clearing app data and login again cannot solve the problem too.

@pd4d10
Copy link
Owner

pd4d10 commented Apr 6, 2020

Oh, there seems another problem with organization repo.

I'll try to fix this in the next release.

pd4d10 added a commit that referenced this issue Apr 6, 2020
@pd4d10
Copy link
Owner

pd4d10 commented Oct 5, 2020

Should have fixed in the latest v1.5.1. Sorry for the long wait!

@pd4d10 pd4d10 closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants