Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: back button android, return home on tap #59

Merged
merged 2 commits into from Apr 16, 2020

Conversation

shreyas1599
Copy link
Contributor

Fixes #57 and #54

  • I could not use a list as for some reason indexing with a list did not work. The state was always at null. Instead had to use five variables and reused them for all the platforms.
  • Added a controller for the CupertinoTabScaffold as I need to get the value of index in onWillPop. I initially used a temporary variable and updated its value each time a tab bar item was clicked but because of using await in onWillPop it created trouble. And a controller inherently seems like a better option.

Let me know if there are any changes to be made. Thanks!

lib/home.dart Outdated Show resolved Hide resolved
@pd4d10 pd4d10 merged commit 98f102f into pd4d10:master Apr 16, 2020
@shreyas1599 shreyas1599 deleted the back-options branch January 9, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Back Button closes App
2 participants