Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error displaying repo with 0 files #99

Closed
shreyas1599 opened this issue Aug 16, 2020 · 1 comment
Closed

Error displaying repo with 0 files #99

shreyas1599 opened this issue Aug 16, 2020 · 1 comment

Comments

@shreyas1599
Copy link
Contributor

An error occurs (see image below) when the repo is initialized with zero files. I created a public repo - test to confirm this was not only caused for private repos(I found the problem while opening a private repo). The error is caused by fetchContributors. For example: https://api.github.com/repos/shreyas1599/test/stats/contributors does nothing. Does not even return an error message. I tried using the debugger and it returned an exception on this line of github.dart of SpinlockLabs.

I'm thinking there's no response and jsonDecode is throwing an error because nothing is returned by the request. Could this be the error or am I missing something?

image

@pd4d10
Copy link
Owner

pd4d10 commented Oct 3, 2020

I'm thinking there's no response and jsonDecode is throwing an error because nothing is returned by the request

Yeah, it seems so. Perhaps we should manually catch this error in this case.

@pd4d10 pd4d10 closed this as completed in 3002c07 Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants