Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Git Book ed 1 #1149

Open
pedrorijo91 opened this issue Feb 22, 2018 · 7 comments
Open

Drop Git Book ed 1 #1149

pedrorijo91 opened this issue Feb 22, 2018 · 7 comments

Comments

@pedrorijo91
Copy link
Member

as per discussed on #1140

@jasonlong
Copy link
Member

I'm currently planning on ignoring v1 of the book with the new site design. Would someone else like to 🔥 that version in a separate PR?

@pedrorijo91
Copy link
Member Author

will try to look into this next week @jasonlong , but until there is certainly impossible

@peff
Copy link
Member

peff commented Nov 15, 2018

There are a few translations that are only done for v1, I think. But it has been long enough since v2 came out that I am OK with declaring those as stale and unmaintained. In particular, v1 does not receive any updates at this point.

@jnavila
Copy link
Contributor

jnavila commented Nov 15, 2018

That needs to be reflected in the list of languages. Will submit a PR.

@jnavila
Copy link
Contributor

jnavila commented Nov 16, 2018

How a PR would interact with other ongoing works?

@jasonlong
Copy link
Member

@jnavila Do you mean in regards to the redesign work? If so, I wouldn't worry about that as I'll just merge in whatever changes you make and then figure out what differences exist w/ the new design to account for v2 being the only version.

@jnavila
Copy link
Contributor

jnavila commented Nov 18, 2018

In fact the translations in V1 were already dropped. There is just the Slovene missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants