Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation from Documentation/technical/ not hosted #994

Closed
sxlijin opened this issue Apr 19, 2017 · 4 comments · Fixed by #1025
Closed

Documentation from Documentation/technical/ not hosted #994

sxlijin opened this issue Apr 19, 2017 · 4 comments · Fixed by #1025

Comments

@sxlijin
Copy link
Contributor

sxlijin commented Apr 19, 2017

The Git man pages make occasional references to information in technical/; however, this documentation is not hosted anywhere on the site, so the link 302's to the home page for the docs.

kernel.org does host them FWIW.

@peff thoughts?

@peff
Copy link
Member

peff commented Apr 19, 2017

In ye olden days when git-scm.com was first written, the pages in technical/ did not even build to HTML. And since there's so rarely referenced by the main documentation, nobody ever noticed or added it. I suspect it would just need some tweaks to the rake task that pulls in the pages. Patches definitely welcome.

@jnavila
Copy link
Contributor

jnavila commented Sep 23, 2017

@sxlijin Can you point to where the 302 happens?

@sxlijin
Copy link
Contributor Author

sxlijin commented Sep 27, 2017

@jnavila see #512

$ curl -is http://git-scm.com/docs/technical/api-credentials.html | head -n 1
HTTP/1.1 301 Moved Permanently

Not sure why curl doesn't get a 302. On Chrome 60.0.3112.113 for Windows, I get a 307 (to upgrade from http to https) and then a 302. I'm not sure which of the request headers trigger it, or if it's a cookie, but I doubt it's particularly relevant.

@peff
Copy link
Member

peff commented Sep 27, 2017

The 301 is to redirect you to https, and then you get the 302 (curl doesn't follow the redirects by default, but if you add in -L you can see it switching to HTTP/2. Neat!).

I'm not sure about the 307. It's obviously accomplishing the same thng, but it's interesting that the server generates a different code. This is all Cloudflare, so they may tailor the response based on user-agent sniffing.

Anyway, that's all orthogonal to the actual problem that we don't import the technical/ docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants