Skip to content

Commit

Permalink
Make sure 'make install' does not have to rebuild templates.
Browse files Browse the repository at this point in the history
The dependency rule in templates directory forced 'make install'
that immediately followed 'make all' to rebuild boilerplates.
This was problematic for a workflow that built first as yourself
and then installed as root, from a working tree that is on an
NFS mounted filesystem that is unwritable by root.

Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Junio C Hamano committed Oct 9, 2005
1 parent e1e9c25 commit 8c51242
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions templates/Makefile
Expand Up @@ -6,13 +6,15 @@ prefix ?= $(HOME)
template_dir ?= $(prefix)/share/git-core/templates/ template_dir ?= $(prefix)/share/git-core/templates/
# DESTDIR= # DESTDIR=


all: boilerplates custom all: boilerplates.made custom
find blt find blt


# Put templates that can be copied straight from the source # Put templates that can be copied straight from the source
# in a file direc--tory--file in the source. They will be # in a file direc--tory--file in the source. They will be
# just copied to the destination. # just copied to the destination.
boilerplates:
bpsrc = $(filter-out %~,$(wildcard *--*))
boilerplates.made : $(bpsrc)
ls *--* 2>/dev/null | \ ls *--* 2>/dev/null | \
while read boilerplate; \ while read boilerplate; \
do \ do \
Expand All @@ -25,14 +27,15 @@ boilerplates:
*) cp $$boilerplate blt/$$dst ;; \ *) cp $$boilerplate blt/$$dst ;; \
esac || exit; \ esac || exit; \
done || exit done || exit
date >$@


# If you need build-tailored templates, build them into blt/ # If you need build-tailored templates, build them into blt/
# directory yourself here. # directory yourself here.
custom: custom:
: no custom templates yet : no custom templates yet


clean: clean:
rm -rf blt rm -rf blt boilerplates.made


install: all install: all
$(INSTALL) -d -m755 $(DESTDIR)$(template_dir) $(INSTALL) -d -m755 $(DESTDIR)$(template_dir)
Expand Down

0 comments on commit 8c51242

Please sign in to comment.