Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for jdk 17? #1420

Open
xdev965 opened this issue Jun 23, 2022 · 2 comments
Open

support for jdk 17? #1420

xdev965 opened this issue Jun 23, 2022 · 2 comments

Comments

@xdev965
Copy link

xdev965 commented Jun 23, 2022

Gitblit is great,The only problem is that it does not support jdk >=17。Is there plan support? Is there a specific timeline?

@xdev965 xdev965 changed the title Can gitblit support jdk lts 17 support for jdk 17? Oct 21, 2022
@flaix
Copy link
Member

flaix commented Oct 27, 2022

Yes, there is the goal to support Java 17.
No, there is no specific timeline. I wouldn't say there is any specific timeline with Gitblit.
The Java 17 issue is an especially vast one. The problem with Java 17 is that many changes since Java 9, that so far only issued warnings, are now forbidden and the JVM fails to start. This might be possible to work around by setting the --add-opens option. But for how long?

The correct way is to update Gitblit's dependencies to versions that work with Java 17. Its just that they are all very old. Currently Gitblit doesn't start under Java 17 because of Guice. Once Guice is updated to a version that runs under Java 17, there will be problems with Pegdown, i.e. Parboiled. Which cannot simply be updated, but must be completely replaced by another library for Markdown parsing. So I cannot say how long this is going to take.

@fbacchella
Copy link
Contributor

I’m running an instance of gitblit as a war embeded in tomcat 9, running with a Temurin 21 JVM. So far, so good.
Adding an automatic module name might be a quick win, see https://dev.java/learn/modules/automatic-module/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants