Generated tree-zip files corrupted when submodule present

[gitblit]

Originally reported on Google Code with ID 151

What steps will reproduce the problem?
1. Go to http://demo-gitblit.rhcloud.com/tree/submodules!textmate.git
2. Click on "zip"
3. Try to open the generated zip-file

What is the expected output? What do you see instead?
The zip file should contain the whole tree and should be useable but unzipping it gives
an error.

What version of the product are you using? On what operating system?
v1.2.0-SNAPSHOT

Please provide any additional information below.
On my machine, gitblit gives the following error:
ERROR /.../.../gitblit/git/test.git failed to zip files from commit 79d1eec5b57262a93edb19d6f8ef4838f45f44f3
org.eclipse.jgit.errors.MissingObjectException: Missing blob 3fa7c46d11b11d61f1cbadc6888be5d0eae21969
    at org.eclipse.jgit.storage.file.WindowCursor.getObjectSize(WindowCursor.java:140)
    at com.gitblit.utils.JGitUtils.zip(JGitUtils.java:1760)
    at com.gitblit.DownloadZipServlet.processRequest(DownloadZipServlet.java:128)
    at com.gitblit.DownloadZipServlet.doGet(DownloadZipServlet.java:159)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:770)
    at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:652)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1329)
    at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:294)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1300)
    at com.gitblit.AccessRestrictionFilter.doFilter(AccessRestrictionFilter.java:184)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1300)
    at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:445)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
    at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:559)
    at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:227)
    at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1038)
    at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:374)
    at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:189)
    at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:972)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
    at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
    at org.eclipse.jetty.server.Server.handle(Server.java:363)
    at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:483)
    at org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:920)
    at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:982)
    at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:635)
    at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)
    at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)
    at org.eclipse.jetty.io.nio.SslConnection.handle(SslConnection.java:196)
    at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:627)
    at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:51)
    at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
    at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
    at java.lang.Thread.run(Thread.java:680)

The 3fa7c46d11b11d61f1cbadc6888be5d0eae21969 is the HEAD-hash for the submodule.

Reported by agh.stuttgart on 2012-10-18 11:18:51

[gitblit]

Nice one.

Reported by James.Moger on 2012-10-18 11:47:07

• Status changed: Accepted
• Labels added: Milestone-1.2.0

[gitblit]

Reported by James.Moger on 2012-10-30 21:34:57

• Status changed: Queued

[gitblit]

v1.2.0 has been deployed.

Reported by James.Moger on 2013-01-01 01:06:25

• Status changed: Fixed