Security Information Wiped

[gitblit]

Originally reported on Google Code with ID 180

What steps will reproduce the problem?
1. Run GitBlit on Tomcat for an extended period of time.
2. Errors occur updating team model
ERROR Failed to update team model Development!
java.io.IOException: Too many open files
        at java.io.UnixFileSystem.createFileExclusively(Native Method)
        at java.io.File.createNewFile(File.java:947)
        at org.eclipse.jgit.storage.file.LockFile.lock(LockFile.java:159)
        at org.eclipse.jgit.storage.file.FileBasedConfig.save(FileBasedConfig.java:175)
        at com.gitblit.ConfigUserService.write(ConfigUserService.java:808)
        at com.gitblit.ConfigUserService.updateTeamModel(ConfigUserService.java:515)
        at com.gitblit.ConfigUserService.updateTeamModel(ConfigUserService.java:494)
        at com.gitblit.GitblitUserService.updateTeamModel(GitblitUserService.java:246)
        at com.gitblit.LdapUserService.authenticate(LdapUserService.java:197)
        at com.gitblit.GitBlit.authenticate(GitBlit.java:481)
        at com.gitblit.AuthenticationFilter.getUser(AuthenticationFilter.java:111)
        at com.gitblit.AccessRestrictionFilter.doFilter(AccessRestrictionFilter.java:142)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
        at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:859)
        at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:602)
        at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
        at java.lang.Thread.run(Thread.java:722)

What is the expected output? What do you see instead?
This seemed to wipe out our security settings for one of our repositories, losing the
information forever.  I would expect that a failure of sorts would not effect any repository
settings.

What version of the product are you using? On what operating system?
v1.1.0 on Tomcat 7 on RHEL5

Reported by johnedc on 2012-12-14 13:20:25

[gitblit]

Hi John,

When you say repository settings I assume you mean repository security settings.  Those
are the only "repository" settings stored by the user service.  I suspect the real
problem is that the LDAPUserService in 1.1.0 has a connection leak.  This exception
can occur when exceeding the per-process limit of open file handles (or socket handles
or pipe handles).  The LDAPUserService does not properly close connections which can
eventually lead to this situation. (issue 435)

https://demo-gitblit.rhcloud.com/commit/gitblit.git/301adb550d1d45bbbc6344252dd9cf1c628122d3

Reported by James.Moger on 2012-12-14 17:40:39

[gitblit]

The real cause of this bug has been fixed and is queued for release.  I'm marking this
as a duplicate and merging with issue 435.

Reported by James.Moger on 2012-12-21 21:58:29

• Status changed: Duplicate
• Labels added: Milestone-1.2.0
• Merged into: Massive LDAP connection leak? #435