Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blame seems to cut off #550

Closed
gitblit opened this issue Aug 12, 2015 · 3 comments
Closed

Blame seems to cut off #550

gitblit opened this issue Aug 12, 2015 · 3 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 254

What steps will reproduce the problem?
1. Open https://git.wikimedia.org/blame/operations%2Fmediawiki-config.git/HEAD/wmf-config%2FInitialiseSettings.php
2. View the blame cut off at line 19

What is the expected output? What do you see instead?
The whole file should be blamed. Instead only the first 19 lines are.

What version of the product are you using? On what operating system?
1.2.1 (had to downgrade, sorry)

Please provide any additional information below.
Compare https://git.wikimedia.org/raw/operations%2Fmediawiki-config.git/HEAD/wmf-config%2FInitialiseSettings.php
for the full file, which shows fine.

Reported by chorohoe@wikimedia.org on 2013-06-11 20:14:22

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

This is an interesting one.  I am still tracking it down.  The bulk of the blame generation
is done by JGit and that code is returning a null commit for line 19.  Not sure why.
Strange.

Reported by James.Moger on 2013-06-12 00:53:06

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

It looks like JGit blame generation may have some issues properly dealing with merge
commits.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=374382

I have implemented a workaround to deal with the missing commit information which will
at least not "clip" the annotated view.  The real fix will have to be implemented by
upstream.

Reported by James.Moger on 2013-06-13 00:24:32

  • Status changed: Queued
  • Labels added: Milestone-1.3.0

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Fix or enhancement released in v1.3.0

Reported by James.Moger on 2013-07-14 16:52:58

  • Status changed: Fixed

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.3.0 milestone Dec 13, 2016
@flaix flaix added this to the 1.3.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants