Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced "my tickets" page. Using filters and search. #175

Merged
merged 2 commits into from Apr 24, 2014

Conversation

Hybris95
Copy link
Contributor

This new page is based on the "TicketsPage" layout.

I removed the milestone part (yet).

By default, the page will show the tickets you "watch".
And if the query is removed by hand, it will still show the tickets you "watch".

The search button also shows the tickets you "watch", maybe this must be changed..

@Hybris95
Copy link
Contributor Author

This patch needs to fix the fact that choosing another query filter can make you see some tickets that are not filtered by being "yours".

For example : select "bugs" tickets and it will show you every bug tickets not only those you watch/etc...

@gitblit gitblit merged commit 1e117f1 into gitblit-org:mytickets Apr 24, 2014
@gitblit
Copy link
Collaborator

gitblit commented Apr 24, 2014

I've merged your changes and massaged it some more. It's pretty functional now and looks more or less like I envisioned, but I hate all the code duplication between this page and the repo tickets page. I will probably refactor both to hopefully consolidate common code.

Do you see any thing that we are missing?

@Hybris95
Copy link
Contributor Author

Im fetching on my other computer, testing and I will tell you.
But right now considering the code I am watching, that sounds pretty good.
Maybe some traductions are necessary ?

For sure code factorisation is needed between TicketsPage and MyTicketsPage, I was just not comfortable enough with this project to do this yet.

@Hybris95
Copy link
Contributor Author

I see one thing that could be improved, searching for tickets on which you are responsible.
For example : user1 creates a ticket on which user2 is responsible
user2 cant see the ticket anywhere if he's not watching the ticket so maybe add a filter for those tickets ?

Edit : #177

gitblit added a commit that referenced this pull request Sep 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants