New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match longest repository path towards the shortest #950

Merged
merged 1 commit into from Nov 18, 2015

Conversation

Projects
None yet
4 participants
@saper
Contributor

saper commented Nov 11, 2015

Try to to match longest repository paths first:

mediawiki/extensions/SemanticMediaWiki
mediawiki/extensions
mediawiki

Bug: #949

@saper

This comment has been minimized.

Show comment
Hide comment
@saper

saper Nov 11, 2015

Contributor

I think the better fix would be to move all the logic to something like RepositoryManager.getRepositoryFromURLPath(String), but I'm too unfamiliar with the code to propose a patch.

Contributor

saper commented Nov 11, 2015

I think the better fix would be to move all the logic to something like RepositoryManager.getRepositoryFromURLPath(String), but I'm too unfamiliar with the code to propose a patch.

Match longest repository path towards the shortest
Try to to match longest repository paths first:

mediawiki/extensions/SemanticMediaWiki
mediawiki/extensions
mediawiki

Bug: #949
@paladox

This comment has been minimized.

Show comment
Hide comment
@paladox

paladox Nov 15, 2015

Contributor

+1 I haven't tested but looks good.

And gitblit really does need support for these paths.

Contributor

paladox commented Nov 15, 2015

+1 I haven't tested but looks good.

And gitblit really does need support for these paths.

gitblit added a commit that referenced this pull request Nov 18, 2015

Merge pull request #950 from saper/searchlast
Match longest repository path towards the shortest

@gitblit gitblit merged commit a5cf407 into gitblit:master Nov 18, 2015

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Nov 18, 2015

Owner

@saper Thanks. Looks good, works fine.

Owner

gitblit commented Nov 18, 2015

@saper Thanks. Looks good, works fine.

@saper

This comment has been minimized.

Show comment
Hide comment
@saper

saper Nov 18, 2015

Contributor

Thank you!

Contributor

saper commented Nov 18, 2015

Thank you!

paladox added a commit to paladox/gitblit that referenced this pull request Nov 23, 2015

Copied from https://github.com/saper/gitblit/blob/c4e5664d9b7bf19dd0f…
…9dee79c8cb0d45f56bb54/src/main/java/com/gitblit/servlet/RawServlet.java

This was originally from gitblit#950 but seems to have been reverted when develop branch was merged with master.

gitblit added a commit that referenced this pull request Nov 23, 2015

Match longest repository path towards the shortest pr-950
This was originally from #950 but seems to have been reverted when develop branch was merged with master.

@fzs fzs modified the milestone: 1.8.0 Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment