Skip to content
This repository has been archived by the owner on Feb 21, 2019. It is now read-only.

Don't work in slate 0.37 #45

Closed
linonetwo opened this issue Aug 18, 2018 · 8 comments
Closed

Don't work in slate 0.37 #45

linonetwo opened this issue Aug 18, 2018 · 8 comments

Comments

@linonetwo
Copy link

Don't work in local development, try to reproduce in an online environment but there is another bug.
https://stackblitz.com/edit/react-fh7kbo?file=index.js

@linonetwo
Copy link
Author

wx20180818-160922 2x

I add border to code block, seems that "enter" will add a new code block instead of a code line.

@linonetwo
Copy link
Author

linonetwo commented Aug 18, 2018

OK, seems plugin is completely not working with slate@0.37
There are lots of API breaking change, I will take a look into it, and submit a PR if I can.

@linonetwo linonetwo changed the title command + enter don't work in slate 0.37 Don't work in slate 0.37 Aug 18, 2018
@linonetwo
Copy link
Author

@Soreine @SamyPesse
I've made it worked.
#46

@Soreine
Copy link
Contributor

Soreine commented Aug 19, 2018

Thanks a lot :)

@linonetwo
Copy link
Author

Closing due to the close of PR #46 (comment)
I may publish another npm package likes slate-code-block or so from my forked version since it's Apache License 2.0?

@Soreine
Copy link
Contributor

Soreine commented Oct 6, 2018

Yes you can :)

https://tldrlegal.com/license/apache-license-2.0-(apache-2.0)

@cdunn
Copy link

cdunn commented Nov 12, 2018

@linonetwo did you ever get around to publishing somewhere? just starting down the road of updating all the slate plugin forks. thanks!

@linonetwo
Copy link
Author

@cdunn I've published it as https://www.npmjs.com/package/slate-code-block.

Thought there are some breaking changes in slate 0.40, I will adapt to that soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants