Separate SMTP settings from the GitBucket "base" settings for the plugin

[laaksokimmo]

SMTP settings for the announce should be splitted up:

• SMTP settings (announce plugin)
• SMTP notification settings ("base" GitBucket)

Doing so, we could separate the GIT notifications and it's underlying SMTP usage from any other feature that would require to send email.

We needed to remove the "base" SMTP settings and "send notifications" from the bare GitBucket configuration since it became too verbose with no ability to modity to whom and when the emails are sent out. This, naturally disables the possibility to use announce plugin.

[McFoggy]

The issue is not really announce plugin related. I created instead gitbucket/gitbucket#893.

The split has first to be done in gitbucket then we will adapt if needed.

[McFoggy]

@laaksokimmo I have pushed PR gitbucket/gitbucket#896 to answer the need.
A small change will be required in this plugin to adapt to the proposed new gitbucket settings.

[laaksokimmo]

Cool, waiting takezoe to react.

[laaksokimmo]

I can verify this is working now, thank you for your actions.

[McFoggy]

Ok fine