Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Merge in png PR from gitcoinco/web/master #166

Closed
jasonrhaas opened this issue Oct 9, 2018 · 4 comments
Closed

Merge in png PR from gitcoinco/web/master #166

jasonrhaas opened this issue Oct 9, 2018 · 4 comments
Assignees
@jasonrhaas
Projects
Kudos

Comments

@jasonrhaas
Copy link
Collaborator

gitcoinco/web#2346 (comment)
@jasonrhaas jasonrhaas created this issue from a note in Kudos (To Do) Oct 9, 2018
@jasonrhaas jasonrhaas self-assigned this Oct 9, 2018
@owocki
Copy link
Contributor

owocki commented Oct 9, 2018

@jasonrhaas i'd suggest adding this to the scope:

  • all emails must show png instead of svg for any related kudos
  • any twitter unfurl link for a kudos detail page should be the png, not the svg. (see cards_pic.html in the codebase)

@jasonrhaas jasonrhaas moved this from To Do to In progress in Kudos Oct 11, 2018
@owocki
Copy link
Contributor

owocki commented Oct 16, 2018

is this still in progress? its blocking #183

@jasonrhaas
Copy link
Collaborator Author

@owocki yes... I started working it and then dropped it to do the deployments to rinkeby and mainnet. Getting back to it today.

@jasonrhaas jasonrhaas moved this from In progress to To Do in Kudos Oct 18, 2018
@owocki
Copy link
Contributor

owocki commented Oct 23, 2018

882a71ffb8a92123aa6030a2ebda64b482870d39 should take care of this...

no need to store the image file on the obj.. its now generated dynamically

@owocki owocki closed this as completed Oct 23, 2018
Kudos automation moved this from To Do to Done Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasonrhaas jasonrhaas

Labels
None yet
Projects
Kudos
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@owocki @jasonrhaas