Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an admin, I want to create a flow where users can mint new tokens, so tokens can be limited only by users' imaginations and the money they want to give us! #21

Open
owocki opened this issue May 22, 2018 · 14 comments

Comments

Projects
5 participants
@owocki
Copy link
Member

commented May 22, 2018

User Story

As an admin, I want to create a flow where users can mint new tokens, so tokens can be limited only by our imaginations and money!

How it Works

As an admin, I want to create a flow where users can mint new tokens, so tokens can be limited only by our imaginations and money!

Happy Path 1

We enter this flow from the 'mint' token flow, where we stores each of the form fields in the database in a new table called TokenCreationRequests, and manages the token creation. (See Token Creation Ticket)

TokenCreationRequest has the following fields

  • Title
  • Description
  • Price
  • from_user
  • status

When a new TokenCreationRequest is created, an admin-email is sent to settings.ERC721_ADMIN, which will initially map to founders@gitcoin.co.

Django Admin

There is a django admin index for the TokenCreationRequest, we will use that to manage requests that are status == pending. Each row in this table will have a 'process' link if status != 'done'.

There will be a django admin area where we (or a contractor we hire) can process each TokenCreationRequest.

This area will show all of the info above, and a comment thread. On this screen, we can also add staff-only comments to discuss each request. For each comment, one can optionally attach an svg. Each time a new comment is posted, it will send an email to settings.ERC721_ADMIN letting them know about the comment and linking to the thread.

There will be a "Deliver" button which allows a staff member to upload a final SVG to the TokenCreationRequest object. When this happens, status will become done, fulfiller_user will be the staff username, and an email will be sent to the user letting them know their "minting" process is complete.

Subject: Your artifact mint is complete!
Body: img of the new artifact.
manage artifact LINK

screen shot 2018-05-22 at 8 18 27 am

Description

Type:
Feature

@owocki owocki changed the title As an admin, I want to create a flow where users can mint new tokens, so tokens can be limited only by our imaginations and money! As an admin, I want to create a flow where users can mint new tokens, so tokens can be limited only by our imaginations and the money they want to give us! May 22, 2018

@owocki owocki changed the title As an admin, I want to create a flow where users can mint new tokens, so tokens can be limited only by our imaginations and the money they want to give us! As an admin, I want to create a flow where users can mint new tokens, so tokens can be limited only by users' imaginations and the money they want to give us! May 22, 2018

@thelostone-mc

This comment has been minimized.

Copy link
Member

commented May 29, 2018

Does the creator automatically get a copy of the token he created once the minting is complete ?

Or would it be a two step process where once it's minted, he'd have to go and buy it like everyone else despite being a creator ?

And I'm assuming we will have a guideline doc to the users which they need to abide by if they would like to request minting

Also does the rarity influence the price or the other way around

I know the user enters the rarity aka number of clones but he also sets the price ! So it could a super rare token but dirt cheap / a super expensive token with multiple copies ( based on how the user wants it )

They need to figure out the sweet spot to make money ?

Oh this is exciting :D

@owocki

This comment has been minimized.

Copy link
Member Author

commented May 29, 2018

Does the creator automatically get a copy of the token he created once the minting is complete ?

yes

And I'm assuming we will have a guideline doc to the users which they need to abide by if they would like to request minting

yes we already have guidelines for these assets. they were posted recently in the erc721 channel

Also does the rarity influence the price or the other way around

i certainly think it should! here is a ticket to track pricing discussions #35

They need to figure out the sweet spot to make money ?

amen 🙏

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2018

There will be a django admin area where we (or a contractor we hire) can process each TokenCreationRequest.

What if, instead of custom baking a review area in the django admin, we use github issues on a new repo, to manage the creation of the assets. This way (1) the user can be involved in the creation of their art (2) we don't reinvent the wheel from a work management perspective ( messages / assignee / uploads all dont have to be custom baked )

@jasonrhaas jasonrhaas self-assigned this Jun 19, 2018

@jasonrhaas jasonrhaas added this to To do in Kudos via automation Jun 19, 2018

@jasonrhaas jasonrhaas added this to the Kudos V1 milestone Jun 19, 2018

@jasonrhaas jasonrhaas added the v1 label Jun 19, 2018

@jasonrhaas jasonrhaas moved this from To do to Backlog in Kudos Jun 20, 2018

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2018

@PixelantDesign

can we start doing this with miaden? @mbeacom and i can create a new github issues board for you if you want

What if, instead of custom baking a review area in the django admin, we use github issues on a new repo, to manage the creation of the assets. This way (1) the user can be involved in the creation of their art (2) we don't reinvent the wheel from a work management perspective ( messages / assignee / uploads all dont have to be custom baked )

@jasonrhaas jasonrhaas moved this from Backlog to In progress in Kudos Jul 17, 2018

@jasonrhaas jasonrhaas moved this from In progress to To do in Kudos Jul 17, 2018

@jasonrhaas jasonrhaas moved this from To do to In progress in Kudos Jul 17, 2018

@jasonrhaas

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2018

There is a django admin index for the TokenCreationRequest, we will use that to manage requests that are status == pending. Each row in this table will have a 'process' link if status != 'done'.

Why do we need the TokenCreationRequest? If this ticket as "as an admin", can't we just mint it, wait for it to mint and, sync it to the database, and then have it show up in the Marketplace for cloning? Is it necessary to send an email in this case?

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2018

Why do we need the TokenCreationRequest?

Because there is going to be several revisions of the artistic asset in between the request for a new token and the actual creation of the token, (bc design / art is never perfect in the first rev) and we need to have a place to persist the request during that time. Also, it'd be ncie to have analytics around which artists are performing and which aren't.

@jasonrhaas

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2018

Because there is going to be several revisions of the artistic asset in between the request for a new token and the actual creation of the token

Ok, so this ticket is like "Create a Sandbox Working Area for designing new Kudos". But we want it to be "admin only", so not available to new users. In this case, it would be a Sandbox of "In progress" Kudos that are being designed. Once the design in finalized, there will be some kind of flow for turning the "In Progress" Kudos to "Complete". At that point it will be minted on the blockchain.

@PixelantDesign

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2018

I was thinking something like this? Let's discuss...

token creatoin flow

@jasonrhaas

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2018

The flow looks good. @owocki also had the idea of using Github issues or PR's for approvals. That might make sense here, and this way we don't have to re-invent the whole workflow/review process.

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2018

strongly in favor of leveraging github issues (or similar) instead of building our own content creation task management system

above flow looks good. instead of having it go to alisa then to the user, i was thinking of doing 2 rounds of review where anyone on the core team AND the funder of the art are able to comment

@jasonrhaas jasonrhaas moved this from In progress to To do in Kudos Jul 17, 2018

@octavioamu

This comment has been minimized.

Copy link
Collaborator

commented Sep 14, 2018

We really want to do this one for v1? I'm thinking this can be good for v2 or maybe for v1 we can just use github for all the process, I mean just a link to a template isse "mint new kudos request" with the fields we need, until we validate how people use kudos. (like a new icon request of font awesome)

@owocki

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2018

i like the idea of using github for this. we could have a repo with all of the kudos on it, and users could just open up a new issue with a specified template to mint a new request, which we could them assign to one of the illustrators on the team

@jasonrhaas jasonrhaas moved this from To Do to Backlog in Kudos Sep 20, 2018

@PixelantDesign

This comment has been minimized.

Copy link
Collaborator

commented Sep 25, 2018

I think this is V1.5 or V2.

@jasonrhaas

This comment has been minimized.

Copy link
Collaborator

commented Sep 27, 2018

For this one, the mint page will be directed to a Github Issue for V1. For V.next we will have the option of improving this or having a more integrated flow for creating original Kudos tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.