-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Idena stamp into Gitcoin Passport and deploy to staging #1042
Comments
Going to wait to decide how to handle auth process after #869 |
The Idena stamp integration PR has been rebased onto the latest master and is ready to be merged |
@midenaio I pinged in Telegram group, looking for an activation code so I can test once we merge. |
Hey @Jeremy-Gitcoin, please check your Telegram pm for the code |
@midenaio Thank you! |
As part of this, let's draft a generic piece of documentation on we should cache third-party authentication sessions. |
Alright I've merged the caching mechanism to main and provided Idena with an updated branch to review. I also asked Idena to add unit tests and to clarify my thoughts around local testing. I added documentation about the context and caching here. Let me know if you'd like me to prepare something more user-facing or work with one of the devrel guys to put something together. |
The Idena team provided some updates, and this should be good to go! We just need to decide if we want to accept the updates to the expiration_date as-is (i.e. letting Idena set their own expiration dates). This depends on where we settle with our on-chain and ComposeDB schemas. It sounds like we're leaning towards making the expiration date optional and allowing providers to configure their own expiration dates. In which case, the PR is good to merge. |
Hit me up for testing credentials if needed |
Integrate Idena as a stamp into Gitcoin Passport and deploy the updated code to staging for testing. The integration of the Idena stamp will enable Passport users to verify their Idena account and add it to their identity score.
Acceptance Criteria:
Tasks:
The text was updated successfully, but these errors were encountered: