Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Idena stamp into Gitcoin Passport and deploy to staging #1042

Closed
4 of 5 tasks
erichfi opened this issue Mar 27, 2023 · 9 comments · Fixed by #1388
Closed
4 of 5 tasks

Integrate Idena stamp into Gitcoin Passport and deploy to staging #1042

erichfi opened this issue Mar 27, 2023 · 9 comments · Fixed by #1388
Assignees

Comments

@erichfi
Copy link
Collaborator

erichfi commented Mar 27, 2023

Integrate Idena as a stamp into Gitcoin Passport and deploy the updated code to staging for testing. The integration of the Idena stamp will enable Passport users to verify their Idena account and add it to their identity score.

Acceptance Criteria:

  1. The Idena stamp integration code is rebased and merged into the Gitcoin Passport codebase.
  2. The Idena stamp is visible and selectable as an option for Passport users to verify and add to their identity score.
  3. The Idena stamp verification process is working correctly and accurately adds the user's Idena web ID to their identity score.
  4. The updated Gitcoin Passport code with the Idena stamp integration is deployed to staging for testing.

Tasks:

  • Review the Idena stamp integration PR and merge it into the Gitcoin Passport codebase.
  • Implement the necessary changes to the Passport codebase to support the Idena stamp integration.
  • Add the Idena stamp as an option for Passport users to verify and add to their identity score.
  • Test the Idena stamp verification process to ensure it is working correctly and accurately adds the user's Idena account to Passports.
  • Deploy the updated Gitcoin Passport code with the Idena stamp integration to staging for testing.
@lucianHymer lucianHymer self-assigned this Mar 28, 2023
@lucianHymer
Copy link
Collaborator

Going to wait to decide how to handle auth process after #869

@midenaio
Copy link

midenaio commented May 1, 2023

The Idena stamp integration PR has been rebased onto the latest master and is ready to be merged

@Jkd-eth
Copy link

Jkd-eth commented May 16, 2023

@midenaio I pinged in Telegram group, looking for an activation code so I can test once we merge.

@midenaio
Copy link

Hey @Jeremy-Gitcoin, please check your Telegram pm for the code

@Jkd-eth
Copy link

Jkd-eth commented May 17, 2023

@midenaio Thank you!

@erichfi
Copy link
Collaborator Author

erichfi commented May 23, 2023

As part of this, let's draft a generic piece of documentation on we should cache third-party authentication sessions.

@lucianHymer
Copy link
Collaborator

Alright I've merged the caching mechanism to main and provided Idena with an updated branch to review.

I also asked Idena to add unit tests and to clarify my thoughts around local testing.

I added documentation about the context and caching here. Let me know if you'd like me to prepare something more user-facing or work with one of the devrel guys to put something together.

@lucianHymer
Copy link
Collaborator

The Idena team provided some updates, and this should be good to go! We just need to decide if we want to accept the updates to the expiration_date as-is (i.e. letting Idena set their own expiration dates).

This depends on where we settle with our on-chain and ComposeDB schemas. It sounds like we're leaning towards making the expiration date optional and allowing providers to configure their own expiration dates. In which case, the PR is good to merge.

@lucianHymer
Copy link
Collaborator

Hit me up for testing credentials if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants