Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiate and Manage 1-Click Verification Post-Onboarding #2436

Closed
1 task
erichfi opened this issue Apr 30, 2024 · 4 comments · Fixed by #2463, #2497 or #2517
Closed
1 task

Initiate and Manage 1-Click Verification Post-Onboarding #2436

erichfi opened this issue Apr 30, 2024 · 4 comments · Fixed by #2463, #2497 or #2517
Assignees

Comments

@erichfi
Copy link
Contributor

erichfi commented Apr 30, 2024

User Story:

As a user who has just completed the onboarding flow,
I want to automatically start the 1-Click Verification process,
So that I can ensure my stamps are verified while still being able to use other functionalities of the dashboard.

Acceptance Criteria

GIVEN I have completed the onboarding flow and am redirected to the dashboard,
WHEN the 1-Click Verification process begins,
THEN the score display should enter a "loading" state and the verify button for stamps should be disabled, while other dashboard functionalities remain operational.

GIVEN I already have a stamp that we find,
WHEN the flow completes
THEN we should reissue this stamp even though I already possess it.

Product & Design Links:

Figma Link: https://www.figma.com/file/FOOlLEFaBt87atw6CPkA5P/Passport-App?type=design&node-id=8886%3A2839&mode=design&t=A95YBtu2alZO5RG0-1

Tech Details:

  • Implement the dashboard so that during the 1-Click Verification process, the score widget shows a "loading" state and the verify button in the stamp sidebar is disabled.
  • Ensure all other dashboard functionalities, not related to stamp verification or score calculations, are accessible and operational.

Open Questions:

  • What is the right copy for the loading Scorer widget?

Notes/Assumptions:

  • Assumes that the system has the necessary back-end support to manage the state of various UI components based on the verification status.
@digitalmnt digitalmnt self-assigned this May 15, 2024
@digitalmnt
Copy link
Member

Do we have text for the tooltip?

Image

@erichfi
Copy link
Contributor Author

erichfi commented May 22, 2024

Context

While working on the recent issue related to the "updating" process, I've identified a few areas that require adjustments to enhance user experience and efficiency. Below are specific feedback points:

Key Points of Feedback

  1. Allow Users to Claim Non-Web3 Stamps During "Updating":

    • Current Behavior: Users are unable to claim any Stamps while the "updating" process is happening.
    • Feedback: Users should be able to claim any Stamps that are not part of the Web3 flow even during the "updating" process. This would prevent unnecessary waiting times and improve the overall user experience.
  2. Sidebar Updates for Web3 Stamps Verification:

    • Current Behavior: The sidebar only disables the verify button for Web3 Stamps being verified.
    • Feedback: In addition to disabling the verify button, the sidebar should also display the respective "verify" buttons in a "Verifying" state with a spinning animation. This visual feedback will clearly indicate that the verification process is ongoing and help users understand the status at a glance.
  3. Performance Concerns:

    • Observation: The updating process took a significant amount of time.
    • Feedback: This extended duration needs to be investigated. Is the delay due to review resourcing or is there another underlying reason? Understanding the root cause will help us address any bottlenecks and optimize the process.

Action Items

  1. Implement functionality to allow users to claim non-Web3 Stamps during the "updating" process.
  2. Update the sidebar UI to show Web3 Stamps verify buttons in a "Verifying" state with a spinning animation during verification.
  3. Conduct an analysis to determine the cause of the long updating times and propose solutions to reduce this delay.

Conclusion

Addressing these points will significantly improve the user experience during the updating process and provide clearer feedback to users about ongoing verifications. Additionally, understanding and resolving the performance issues will enhance overall system efficiency.

Please let me know if you need any further details or if there are additional aspects you'd like to discuss.

@erichfi erichfi reopened this May 22, 2024
@digitalmnt
Copy link
Member

digitalmnt commented May 22, 2024

@erichfi heres a video showing whats going on behind the scenes. https://drive.google.com/file/d/1hL6NS2mKMmU3kFPTlLKmIZRuEwMHb1Nb/view?usp=sharing Happy to pair on it tomorrow as well.

  1. This is strange I'm able to claim stamps that are not found in the one click verification process while testing on review.
  2. In the video you can see that Verifying is shown within the button. Unfortunately its only shown for a brief moment. This is because the /check request is necessary to determine which stamps we should disable. I tried to demonstrate this in the video. Unfortunately the check request accounts for the majority of the time spent processing
    After our discussion in standup last week I put together chore(app): disable verification for all evm stamps while one click v… #2517 which will disable verification for all evm stamps while one click verification is in progress. Where previously it was only disabling the stamps the address can qualify for.
  3. This is due to us having scaled down resources for the staging/review envs causing the iam requests to take longer. Unfortunately the /check request does take longer than other requests because it is doing a lot more than any other endpoint. As part of the load testing ticket I suggested implementing this endpoint as a lambda which should increase performance. It was also the first endpoint to start having problems once load increases regardless of resources.

@erichfi please let me know if there is anything else to complete

@digitalmnt
Copy link
Member

Just waiting on review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants