Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Refactoring: Decoupling / Pass process.args as parameters #44

Open
ahmad-511 opened this issue Dec 23, 2023 · 0 comments
Open

Code Refactoring: Decoupling / Pass process.args as parameters #44

ahmad-511 opened this issue Dec 23, 2023 · 0 comments

Comments

@ahmad-511
Copy link
Contributor

Instead of depending on process.args inside both writeSQL and readCSV functions, we can simply pass necessary CLI arguments as function parameters.
This will make it easier to maintain and it will also give priority to the function arguments over the CLI argument which can be useful in case (in a future update) we want to dynamically change the output file name (ex: splitting big data into multiple files such as output_1.sql, output_2.sql...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant