Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Player Hunter Pets attacking PVP flagged opposing faction #15

Open
Ghostsupthere opened this issue Apr 26, 2024 · 3 comments
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Ghostsupthere
Copy link

Player hunter pets are attacking opposing faction players if the player gets PVP flagged and the pet is on aggressive.

Ex:

Player A is alliance warrior
Player H is horde hunter

Player A becomes PVP flagged from various means, Player H cannot attack the player manually. If Player H has his pet on aggressive, Player A will be attacked if in range.

I'm not sure .npc info of the pet is any use here, because we tested multiple pets (different factions\ids each time) and different characters. Let me know if you want other information \ what I can gather that could help narrow it down.

image

@Ghostsupthere Ghostsupthere changed the title [BUG] Description of Problem [BUG] Player Hunter Pets attacking PVP flagged opposing faction Apr 26, 2024
@gitdalisar
Copy link
Owner

Interesting... I hadn't considered the pet would have a faction... that's really cool! Nice find!

I'll do some research on this and see how I can resolve it for you!

@gitdalisar gitdalisar reopened this Apr 27, 2024
@gitdalisar gitdalisar added this to the Researching milestone Apr 27, 2024
@gitdalisar
Copy link
Owner

Found faction for pet is defined on line 270 of Pet.cpp so may can hard set that to something factionless. Pinged reporter for info on what actions resulted in PVP Flagging to ensure flagging was not in error.

@Ghostsupthere
Copy link
Author

Unable to confirm cause of PVP flagging still. I have recompiled using the newest .CPP file (to confirm its not the town/city flag) and it still occurs randomly.

Latest occurrence was after a dungeon, some players spawned into town flagged, while others in the same group were not. 1 horde character and 1 alliance character was flagged while another was not. All players spawned into Stormwind after dungeon completion. (Honestly forget the dungeon, didn't note it at the time.)

Will need more testing to report more instance of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants