Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

Consider extacting getEventDetails into own lib #9

Closed
mike182uk opened this issue Jan 11, 2016 · 3 comments
Closed

Consider extacting getEventDetails into own lib #9

mike182uk opened this issue Jan 11, 2016 · 3 comments

Comments

@mike182uk
Copy link
Contributor

The method getEventDetails deals with extracting the event details from the github payload body. This operation would need to be done by any plugin that wanted to integrate with gitevents. Would it make sense to extract this method out to its own lib which could be required in as a dependency? Sort of like a base plugin which provides common utility methods.

@PatrickHeneise
Copy link
Member

quick check: for each plugin you don't get the github payload, but the pre-formatted event/talk from https://github.com/gitevents/core/blob/master/gitevents.js#L69, correct?

@mike182uk
Copy link
Contributor Author

Ah excellent, this is already done in core. For some reason this plugin is parsing the raw Github payload. This plugin should be changed to use the pre-formatted event object thats passed in. I'll close this issue and raise a new one for this change.

@PatrickHeneise
Copy link
Member

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants