Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the statistics plugin, in the "Code by type" tab, allocation of space on the pie chart was wrong. #2530

Closed
clayton-rogers opened this issue Nov 28, 2014 · 0 comments
Milestone

Comments

@clayton-rogers
Copy link
Contributor

In the statistics plugin, in the "Code by type" tab, the pie chart was allocating significantly more angle to the "Lines of code" slice because it was using the total number of lines rather than the actual number of code lines. Fixed by calculating and then using the actual number of code lines.

Before (notice code percentage is ~50%):
statistics before

After:
statistics after

Fix:
http://pastebin.com/gxBgcdEM

@clayton-rogers
Copy link
Contributor Author

Better fix, clearly wasn't reading the code closely:
http://pastebin.com/2X3p3ePv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants