Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option 'Close dialog when all changes are committed' does not work properly #3589

Closed
crypto-rsa opened this issue Mar 14, 2017 · 0 comments
Closed
Milestone

Comments

@crypto-rsa
Copy link
Contributor

crypto-rsa commented Mar 14, 2017

Steps to reproduce:

  1. Make some changes in the repository
  2. Open the commit dialog
  3. Make sure that the Close dialog after each commit option is off, Close dialog when all changes are committed is on and Refresh dialog on form focus is on
  4. Type in some commit message but do not stage anything
  5. Click commit and click Yes to stage and commit all unstaged files

After the commit is performed, there are no uncommitted changes in the repository so according to the settings the dialog should close automatically - but it stays open.

I believe the problem is that in step 5, the unstaged file list is not updated (it still contains all the original changes) and so the value of the AppSettings.CloseCommitDialogAfterLastCommit option is ignored (see line 954 in method DoCommit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants