Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win32Exception when clicking on Revision Link #3763

Closed
pravic opened this issue Jun 15, 2017 · 5 comments
Closed

Win32Exception when clicking on Revision Link #3763

pravic opened this issue Jun 15, 2017 · 5 comments

Comments

@pravic
Copy link

pravic commented Jun 15, 2017

Do you want to request a feature or report a bug?
Report a bug.

What is the current behavior?

System.ComponentModel.Win32Exception
Unknown error (0x80041002)
Boolean StartWithShellExecuteEx(System.Diagnostics.ProcessStartInfo) @ System.Diagnostics.Process
at System.Diagnostics.Process.StartWithShellExecuteEx(ProcessStartInfo startInfo)
at GitUI.CommitInfo.CommitInfo.HandleLink(String link, Object sender)
at System.Windows.Forms.RichTextBox.OnLinkClicked(LinkClickedEventArgs e)
at System.Windows.Forms.RichTextBox.EnLinkMsgHandler(Message& m)
at System.Windows.Forms.RichTextBox.WmReflectNotify(Message& m)
at System.Windows.Forms.RichTextBox.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
http://c2n.me/3LlMeBR.png
http://c2n.me/3LlMl1B.png

Even if URI is "http://httpbin.org", an exception is raised anyway.

What is the expected behavior?
Guess, opening a web browser with the specified URL.

Which versions of GitExtensions, GIT and Windows are affected by this issue? Did this work in previous versions of our tool?
GitExtensions.exe [2.50RC2]
git version 2.13.0.windows.1 (amd64)
Windows 7 x64 SP1

@jbialobr
Copy link
Member

@pravic
Copy link
Author

pravic commented Jun 16, 2017

Apparently it is not related to ASP.NET service.

Also it happened once already: #3515. And there is #2579. But I don't use # inside link or its caption.

@pravic
Copy link
Author

pravic commented Jun 16, 2017

Well.
NBug have messed the original exception, it was "System.ComponentModel.Win32Exception (0x80004005): Unknown error (0x80041002)".
And this is because GitEx is trying to open an issue:%203763#https://github.com/gitextensions/gitextensions/issues/3763 URI — caption and link fields are glued together.

@jbialobr
Copy link
Member

This time it was the colon :) after Issue:

@pravic
Copy link
Author

pravic commented Jun 18, 2017

Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants