Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitRemoteManager calls GetRefs multiple times #4453

Closed
RussKie opened this issue Feb 10, 2018 · 4 comments
Closed

GitRemoteManager calls GetRefs multiple times #4453

RussKie opened this issue Feb 10, 2018 · 4 comments

Comments

@RussKie
Copy link
Member

RussKie commented Feb 10, 2018

Do you want to request a feature or report a bug?
deficiency, noticed in #4442 (comment)

What is the current behavior?

foreach (var remoteHead in _module.GetRefs(true, true))
{
foreach (var localHead in _module.GetRefs(true, true))

What is the expected behavior?
optimised

Environment you encounter the issue:
master

@NickPolyder
Copy link
Contributor

Hello,
Could i start with this one ?

Thanks,

@gerhardol
Copy link
Member

Could i start with this one ?

Yes please!
The current behavior is that it can take several minutes when adding a new remote when there are some already.
The workaround is to deactivate all existing remotes when adding a new

@NickPolyder
Copy link
Contributor

@gerhardol should i use master branch or the latest release ?
Thanks,

@gerhardol
Copy link
Member

Create a branch from master. If this is reasonable in a maintenance branch it will be cherry picked to the 2.51 branch later.

@RussKie RussKie added this to the 3.00 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants