Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for VS addin prior to .vsix #4752

Closed
gerhardol opened this issue Apr 2, 2018 · 7 comments
Closed

Remove support for VS addin prior to .vsix #4752

gerhardol opened this issue Apr 2, 2018 · 7 comments

Comments

@gerhardol
Copy link
Member

gerhardol commented Apr 2, 2018

Do you want to request a feature or report a bug?
bug

What is the current behavior?
GE supports building VS addin. In 2015/2017 the .vsix format is used primarily, but older MSVS can only use the old plugins.

The VS addins are ditributed in the installer.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

What is the expected behavior?
Drop support for addin format (remove the GitPlugin project, not related to the GE plugins).

Considered but dropping from the issue:
The .vsix build should be published on AppVeyor and for GitHub releases too, currently it is only updated occasionally to Microsoft for users that do not build the vsix plugin explicitly. (Current version is 2.50.02)

Environment you encounter the issue:

  • GitExtensions version: master

Did this work in previous version of GitExtensions (which)?
unknown status for the addin

@sharwell
Copy link
Member

sharwell commented Apr 2, 2018

In 2015/2017 the .vsix format is used primarily, but older MSVS can only use the old plugins.

The VSIX can be modified to work with 2012+ (if necessary).

@gerhardol
Copy link
Member Author

I have added the vsix as an artifact for AppVeyor in my private build, but the size differs between the local build (220KB) and in AppVeyor (15MB). The AppVeyor build seem to include the complete GE binaries which should not be necessary as the VSIX uses the GE installation.
Hints?

@RussKie
Copy link
Member

RussKie commented Apr 6, 2018

Personally I don't see a great value publishing the VSIX for every build. It isn't changed very often.

@sharwell
Copy link
Member

sharwell commented Apr 7, 2018

@gerhardol my vsix publishing update PR fixes it

@RussKie
Copy link
Member

RussKie commented Apr 27, 2018

The VSIX can be modified to work with 2012+ (if necessary).

👍
I don't see any compelling reason to support anything older than VS2015.

@gerhardol
Copy link
Member Author

Will not do much in some days: My pc broke some days ago. I purchased new parts but they were faulty and now I am waiting for the shop to repair in the middle of bank holidays.

@RussKie
Copy link
Member

RussKie commented Apr 30, 2018

Bugger... Enjoy your break from us 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants