Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff list: Collapse indicator of headings not clickable and can be invisible #5332

Closed
mstv opened this issue Aug 20, 2018 · 7 comments
Closed

Comments

@mstv
Copy link
Member

mstv commented Aug 20, 2018

Do you want to request a feature or report a bug?
ux improvement

What is the current behavior?
The heading of a diff list can be double clicked what will collapse/expand the list.
But neither a single nor a double click on the collapse indicator have an effect.
grafik
The collapse indicator can become invisible.
grafik

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

What is the expected behavior?
The diff list should be collapsed/expanded by single clicking the collapse indicator.
The collapse indicator should always be visible.
grafik

Environment you encounter the issue:

  • GitExtensions version: master
  • GIT version: 2.17.1.w.2-x64
  • OS version: Windows 7
  • .NET version: 4.7

Did this work in previous version of GitExtensions (which)?
have not checked yet

@RussKie RussKie added this to the 3.00 milestone Aug 20, 2018
@RussKie RussKie added type: regression regression, normally to latest official release area: user experience labels Aug 20, 2018
@RussKie
Copy link
Member

RussKie commented Aug 20, 2018

The indicator was never clickable, the existing implementation doesn't handle this event. While it is an annoyance, it isn't a high priority issue right now. PRs are welcome though.

The fact that it may get invisible is a regression however.

@gerhardol
Copy link
Member

gerhardol commented Aug 20, 2018

You can double click the label to expand/collapse
Edit: I agree that this should be improved, but the prio is low.

@mstv
Copy link
Member Author

mstv commented Aug 20, 2018

I know, but it's not very intuitive to me. I don't use it every day. That's why it always takes some time until I remember / find out again how to do it. I agree that the additional event handler has low priority.

@mstv
Copy link
Member Author

mstv commented Aug 22, 2018

Today, I noticed that the indicator gets invisible when the scrollbar is activated due to long file names:
grafik
grafik

@gerhardol
Copy link
Member

So this is not a regression at least?

@mstv
Copy link
Member Author

mstv commented Aug 22, 2018

Yes, no regression -- especially because I cannot see the indicator in 2.51.02 at all:
grafik

@gerhardol gerhardol removed the type: regression regression, normally to latest official release label Aug 23, 2018
@RussKie RussKie removed this from the 3.00 milestone Aug 23, 2018
@pmme
Copy link
Contributor

pmme commented Sep 4, 2018

Also in #4886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants