Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI hangs after loading repo #5408

Closed
gerhardol opened this issue Sep 7, 2018 · 1 comment
Closed

GUI hangs after loading repo #5408

gerhardol opened this issue Sep 7, 2018 · 1 comment
Labels
area: performance type: regression regression, normally to latest official release
Milestone

Comments

@gerhardol
Copy link
Member

Do you want to request a feature or report a bug?
bug - regression

What is the current behavior?
The GE GUI can hang from a couple of seconds to a minute when opening the application, switch repo or force refresh. The background can be gray or GE just not responding.

The problem is not very visible in the GE repo but I see the it in repos with many submodules, about 30 in several layers. The problem started around or after the threading change. The handling was much improved with #5087, before then submodule status diff would occur more often.

When the problem occurs, it may occur while some git commands are running according to the Git log, about the same time as the hanging occurs. I do not believe the commands are causing the hang, but the problem occurs at that time

  • git for-each-ref --sort=-committerdate refs/heads/ --format="%(objectname) %(refname)"
  • git show-ref --dereference
    If in a submodule and View-Show supermodule* settings are activated, the ls-tree commands (one for each superrepo branch) starts after the "hang".

The problem seem to be related to starting several commands at about the same time.

Note: the PC where I primarily see the problem has Symantec installed, but I do not see how that causes these random hanging in master only as I do not see this with 2.51.

Note2: Git 2.19r1 optimizes "stash list" and seem to improve this problem

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

  • Repo with many submodules?
  • Refresh

What is the expected behavior?
No "hang", the updates should be done in the background

Environment you encounter the issue:

  • GitExtensions version: 58f3b6c
  • GIT version: 2.18 (2.19rc1)
  • OS version: Win7
  • .NET version: 4.6.1

Did this work in previous version of GitExtensions (which)?
2.51 is slower when master works, but 2.x did not hang

@gerhardol gerhardol added type: regression regression, normally to latest official release area: performance labels Sep 7, 2018
@RussKie RussKie added this to the 3.00 milestone Sep 8, 2018
@RussKie RussKie modified the milestones: 3.00, 3.00-beta2 Sep 26, 2018
@gerhardol
Copy link
Member Author

Fixed in #5487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: performance type: regression regression, normally to latest official release
Projects
None yet
Development

No branches or pull requests

2 participants