Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules dialog and parenthesis in path #5469

Closed
ggnkua opened this issue Sep 22, 2018 · 4 comments
Closed

Submodules dialog and parenthesis in path #5469

ggnkua opened this issue Sep 22, 2018 · 4 comments

Comments

@ggnkua
Copy link

ggnkua commented Sep 22, 2018

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

I have a project in which a few submodules contain open and close parentheses in the path. This results into something like the following screenshot:

image

"Name" field should contain ASM/Various/Sascha Springer (Anima)/chorenshabut as you see is completely empty. Also, "Local path" seems to have spilled over to "Branch" field.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

Clone the repository I linked above and init/update submodules or import a repository as a submodule into a repository with the name containing opening parenthesis character (.

What is the expected behavior?

"Name", "Local path", "Branch" fields in the submodules dialog should be filled out correctly

Environment you encounter the issue:

  • GitExtensions version: 2.51.05
  • GIT version: 2.18.0
  • OS version: Windows 10
  • .NET version: No idea. It doesn't appear on Windows 10 installed programs lists (under settings or control panel applet)

Did this work in previous version of GitExtensions (which)?

No

@gerhardol gerhardol changed the title Submodules dialog gets confused Submodules dialog and parenthesis in path Oct 5, 2018
@mdonatas
Copy link
Contributor

I am running a few weeks old master build and the bug seems fixed there:
image

@ggnkua
Copy link
Author

ggnkua commented Oct 16, 2018

Hey, that's super cool! Is there any ETA on the next release by chance?

@gerhardol
Copy link
Member

Is there any ETA on the next release by chance?

Beta1 is released. A beta2 or RC1 is planned quite soon, there has been a stream of incoming PRs lately that has delayed the release...

@RussKie
Copy link
Member

RussKie commented Oct 16, 2018

Thank you.
Closing presumed fixed.

@RussKie RussKie closed this as completed Oct 16, 2018
@RussKie RussKie added this to the 3.00-beta2 milestone Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants