Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double click in empty TextBox raises ArgumentOutOfRangeException #5890

Closed
bluepanter opened this issue Dec 11, 2018 · 2 comments
Closed

Double click in empty TextBox raises ArgumentOutOfRangeException #5890

bluepanter opened this issue Dec 11, 2018 · 2 comments
Labels
type: bug 🐛 type: regression regression, normally to latest official release
Milestone

Comments

@bluepanter
Copy link

Do you want to request a feature or report a bug?
bug

What is the current behavior?
On double click into the empty commit message text box raises an ArgumentOutOfRangeException

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Open Repository -> Click "Commit" -> Double click into the Commit message text box

What is the expected behavior?
Do nothing

Environment you encounter the issue:

  • Git Extensions 3.00.00.4433
  • Build fca7cf2
  • Git 2.20.0.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3221.0
  • DPI 96dpi (no scaling)

Did this work in previous version of GitExtensions (which)?
I don't know.

image

image

@gerhardol
Copy link
Member

gerhardol commented Dec 11, 2018

reproduceable
Added to 3.01.00 milestone, could be considered for 3.00.01 too - if reasonable correction

   at System.Windows.Forms.TextBoxBase.Select(Int32 start, Int32 length)
   at GitUI.SpellChecker.EditNetSpell.TextBox_DoubleClick(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnDoubleClick(EventArgs e)
   at System.Windows.Forms.TextBoxBase.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.RichTextBox.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

@gerhardol gerhardol added this to the 3.01.00 milestone Dec 11, 2018
@gerhardol gerhardol added the type: regression regression, normally to latest official release label Dec 11, 2018
@vbjay
Copy link
Contributor

vbjay commented Dec 11, 2018

On it.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 type: regression regression, normally to latest official release
Projects
None yet
Development

No branches or pull requests

4 participants